Fix MSIX packaging to determine if a Preview release by inspecting the semantic version string #11991
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e semantic version string
8000
PoshChan
reviewed
Mar 2, 2020
| if ($ProductNameSuffix) { | ||
| $packageName += "-$ProductNameSuffix" | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/ADOPTERS.md.https://shell.azure.com/ should work
Failed to complete request to "https://shell.azure.com/". Response status code does not indicate success: 500 (Internal Server Error).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119: throw "Failed to complete request to `"$url`". $($_.Exception.Message)"
PoshChan
reviewed
Mar 2, 2020
Member
|
@PoshChan please retry static, macos |
Collaborator
|
@adityapatwardhan, successfully started retry of |
PoshChan
reviewed
Mar 2, 2020
Member
Author
|
@PoshChan retry static |
|
@SteveL-MSFT, successfully started retry of |
PoshChan
reviewed
Mar 2, 2020
Member
Author
|
@PoshChan retry static |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
adityapatwardhan
approved these changes
Mar 4, 2020
|
🎉 Handy links: |
TravisEz13
pushed a commit
that referenced
this pull request
Sep 9, 2020
…e semantic version string (#11991)
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The non-Preview release still gets a Product Name of "PowerShell Preview" because the code was looking to see if the
$productnamecontains a-. Since the version is added after the product name, it will always have a-such aspowershell-7.0.0. The fix is to only look for the-within the semantic version string like7.0.0-rc.1.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.