8000 Ignore last exit code in the build step as `dotnet` may return error when SDK is not installed by adityapatwardhan · Pull Request #11972 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Ignore last exit code in the build step as dotnet may return error when SDK is not installed #11972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 2 commits into from
Feb 28, 2020
Merged

Ignore last exit code in the build step as dotnet may return error when SDK is not installed #11972

daxian-dbw merged 2 commits into from
Feb 28, 2020

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Feb 28, 2020 •
edited
Loading

PR Summary

When dotnet version installed does not match the version in global.json, dotnet may set a error exit code. Az DevOps has started failing when that happens. The PR addresses that by ignoring the last exit code.

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Feb 28, 2020
SteveL-MSFT
SteveL-MSFT approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: since we have this in 3 places, should consider have it as a helper function, but not necessary for this PR

@daxian-dbw
Copy link
Member
daxian-dbw commented Feb 28, 2020

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator
PoshChan commented Feb 28, 2020

@daxian-dbw, this is the reminder you requested 1 hour ago

@daxian-dbw daxian-dbw merged commit 91c9be9 into PowerShell:master Feb 28, 2020
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 24, 2020
@adityapatwardhan adityapatwardhan added this to the 7.1.0-preview.1 milestone Mar 24, 2020
@ghost
Copy link
ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@adityapatwardhan adityapatwardhan deleted the FixBuildLastExitcode branch June 8, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

5 participants

@adityapatwardhan @daxian-dbw @PoshChan @SteveL-MSFT @TravisEz13
0