8000 Remove hop restrictions for interactive sessions by PaulHigin · Pull Request #11920 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Remove hop restrictions for interactive sessions #11920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 1 commit into from
Feb 28, 2020
Merged

Remove hop restrictions for interactive sessions #11920

anmenaga merged 1 commit into from
Feb 28, 2020

Conversation

@PaulHigin
Copy link
Contributor
@PaulHigin PaulHigin commented Feb 21, 2020 •
edited
Loading

PR Summary

This addresses Issue #2453
This PR allows Enter-PSHostProcess to work from within an SSH remote interactive session.

PR Context

Interactive session second hop support was added a while ago, but current behavior is to restrict a second hop to work only from a WinRM remote session. This is an unnecessary restriction and this PR allows both Enter-PSSession and Enter-PSHostProcess to work from within any interactive remote session.

Example:

PS> Enter-PSSession -HostName localhost
[localhost]: PS> Enter-PSHostProcess 8380
[localhost]: [Process:8380]: PS> $pid
8380
Exit-PSHostProcess
[localhost]: PS> Exit-PSSession
PS>

PR Checklist

@ghost ghost assigned iSazonov Feb 21, 2020
@PaulHigin PaulHigin assigned anmenaga and unassigned iSazonov Feb 21, 2020
SteveL-MSFT
SteveL-MSFT approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please open a doc issue

@PaulHigin PaulHigin mentioned this pull request Feb 21, 2020
Closed
11 tasks
@anmenaga anmenaga added WG-Remoting PSRP issues with any transport layer CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Feb 28, 2020
@anmenaga anmenaga added this to the 7.1-Consider milestone Feb 28, 2020
@anmenaga anmenaga merged commit 00b60c4 into PowerShell:master Feb 28, 2020
@ghost
Copy link
ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@PaulHigin PaulHigin mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@anmenaga anmenaga

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log WG-Remoting PSRP issues with any transport layer

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

5 participants

@PaulHigin @SteveL-MSFT @anmenaga @adityapatwardhan @iSazonov
0