10BC0 Bring back `MainWindowTitle` in `PSHostProcessInfo` by iSazonov · Pull Request #11885 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Bring back MainWindowTitle in PSHostProcessInfo #11885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 2 commits into from
Mar 10, 2020
Merged

Bring back MainWindowTitle in PSHostProcessInfo #11885

TravisEz13 merged 2 commits into from
Mar 10, 2020

Conversation

@iSazonov
Copy link
Collaborator
@iSazonov iSazonov commented Feb 19, 2020 •
edited
Loading

PR Summary

Process.MainWindowTitle is now in .Net Core so bring back MainWindowTitle in PSHostProcessInfo

PR Context

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 19, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Feb 19, 2020
@ghost ghost assigned TravisEz13 Feb 19, 2020
@TravisEz13
Copy link
Member
TravisEz13 commented Feb 19, 2020

Please add tests

@iSazonov
Copy link
Collaborator Author
iSazonov commented Feb 20, 2020

Test was added.

PaulHigin
PaulHigin approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor
@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov force-pushed the restore-pshostprocessinfo-api branch from d4021a6 to e9de728 Compare March 9, 2020 17:29
@TravisEz13 TravisEz13 changed the title Bring back MainWindowTitle in PSHostProcessInfo Bring back MainWindowTitle in PSHostProcessInfo Mar 10, 2020
@TravisEz13 TravisEz13 merged commit 12bf5f4 into PowerShell:master Mar 10, 2020
@iSazonov iSazonov deleted the restore-pshostprocessinfo-api branch March 10, 2020 16:40
@ghost
Copy link
ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

2 more reviewers

@rjmholt rjmholt rjmholt approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

4 participants

@iSazonov @TravisEz13 @rjmholt @PaulHigin
0