8000 Make sure `LTS` packages have symlink for `pwsh` and `pwsh-lts` by TravisEz13 · Pull Request #11843 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@TravisEz13
Copy link
Member
@TravisEz13 TravisEz13 commented Feb 13, 2020

PR Summary

Make sure LTS packages have symlink for pwsh and pwsh-lts

PR Context

PR Checklist

@adityapatwardhan adityapatwardhan added the 8000 CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 13, 2020
@adityapatwardhan adityapatwardhan added this to the GA-consider milestone Feb 13, 2020
function Invoke-CIFinish
{
param(
[string] $NuGetKey
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daxian-dbw, your last commit had 1 failures in PowerShell-CI-linux
Invoke-WebRequest tests.Denial of service.Charset Parsing

Expected the actual value to be greater than 5, but got 0.32999946773053.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1: line 1961
1961:             $pathologicalRatio | Should -BeGreaterThan 5

Copy link
Member Author
@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13 TravisEz13 changed the title Make sure LTS packages have symlink for pwsh and pwsh-lts Make sure LTS packages have symlink for pwsh and pwsh-lts Feb 14, 2020
@TravisEz13 TravisEz13 merged commit d91af72 into PowerShell:master Feb 14, 2020
@TravisEz13 TravisEz13 deleted the fix_lts_packages branch February 14, 2020 02:46
@TravisEz13 TravisEz13 modified the milestones: GA-consider, GA-approved Feb 14, 2020
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
@TravisEz13 TravisEz13 modified the milestones: GA-approved, 7.0.0-rc.3 Feb 19, 2020
@ghost
Copy link
ghost commented Feb 21, 2020

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0