8000 Fix Symlink creation in packaging.psm1 by TravisEz13 · Pull Request #11723 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix Symlink creation in packaging.psm1 #11723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 2 commits into from
Jan 29, 2020
Merged

Fix Symlink creation in packaging.psm1 #11723

anmenaga merged 2 commits into from
Jan 29, 2020

Conversation

@TravisEz13
Copy link
Member
@TravisEz13 TravisEz13 commented Jan 29, 2020 •
edited
Loading

PR Summary

Refactor symlink creation into separate function
Add symlink creation to tarball creation

PR Context

PR Checklist

@TravisEz13 TravisEz13 added this to the GA-consider milestone Jan 29, 2020
@ghost ghost assigned anmenaga Jan 29, 2020
PoshChan
PoshChan reviewed Jan 29, 2020
View reviewed changes
tools/packaging/packaging.psm1
$Arguments = @{
PackageSourcePath = $Source
Name = $Name
Version = $Version
Copy link
Collaborator
@PoshChan PoshChan Jan 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TravisEz13, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/README.md.https://github.com/PowerShell/PowerShell/releases/download/v7.0.0-rc.2/PowerShell-7.0.0-rc.2-win-x64.msi should work

Unable to read data from the transport connection: Connection reset by peer.
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 114
114:                                 $null = Invoke-WebRequest -uri $url -RetryIntervalSec 10 -MaximumRetryCount 6

@anmenaga anmenaga changed the title Fix Symlink creation Fix Symlink creation in packaging.psm1 Jan 29, 2020
@anmenaga anmenaga added Area-Maintainers-Build specific to affecting the build CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Jan 29, 2020
@anmenaga anmenaga merged commit 8206e96 into PowerShell:master Jan 29, 2020
@TravisEz13 TravisEz13 deleted the Fix_symlink_creation branch January 30, 2020 18:58
@TravisEz13 TravisEz13 modified the milestones: GA-consider, GA-approved, 7.0.0 Jan 30, 2020
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
@TravisEz13
Fix Symlink creation in packaging.psm1 (PowerShell#11723)
fc536a5
@ghost
Copy link
ghost commented Feb 21, 2020

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

Area-Maintainers-Build specific to affecting the build CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.3

Development

Successfully merging this pull request may close these issues.

4 participants

@TravisEz13 @adityapatwardhan @PoshChan @anmenaga
0