Revert the PRs that made DBNull.Value and NullString.Value treated as $null
#11648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexx32
approved these changes
Jan 21, 2020
PoshChan
reviewed
Jan 21, 2020
PoshChan
reviewed
Jan 21, 2020
…re turned on by default
Member
Author
|
Revert the changes in |
PoshChan
reviewed
Jan 22, 2020
| /// Used to compare two objects for equality converting the second to the type of the first, if required. | ||
| /// </summary> | ||
| /// <param name="first">First object.</param> | ||
| /// <param name="second">Object to compare first to.</param> |
Collaborator
There was a problem hiding this comment.
@daxian-dbw, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/CHANGELOG/6.0.md.https://msdn.microsoft.com/powershell/reference/6/about/about_jobs should work
Failed to complete request to "https://msdn.microsoft.com/powershell/reference/6/about/about_jobs". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119: throw "Failed to complete request to `"$url`". $($_.Exception.Message)"
iSazonov
reviewed
Jan 22, 2020
iSazonov
approved these changes
Jan 22, 2020
Member
Author
|
@adityapatwardhan Can you please merge this PR? Thanks! |
adityapatwardhan
approved these changes
Jan 29, 2020
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Revert the PRs that made
DBNull.ValueandNullString.Valuetreated as$null:Also update code for Coalescing and Null-conditional operators to use 'IsNull' instead.
This is cherry-picked from the
v7.0.0-rc.2tagged branch. The reversion was did originally in #11584 targeting thev7.0.0-rc.2release branch.Note: there are nice syntax/formatting changes made in the original PRs that I wish we could keep, but making extra changes to keep those in this PR will complicate the reversion and may result in mistakes. So I just revert all changes from those 2 PRs.
PR Context
There has been concerns about the inconsistencies the original changes brought to the language.
See #11604 for the discussion going on.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.