8000 Fixes: Build.psm1 by xtqqczze · Pull Request #11572 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fixes: Build.psm1 #11572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 5 commits into from
Jan 15, 2020
Merged

Fixes: Build.psm1 #11572

TravisEz13 merged 5 commits into from
Jan 15, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Jan 13, 2020 •
edited
Loading

PR Summary

  • Fix typos
  • Refactor code for readability and robustness
  • Fix PSUseCmdletCorrectly rule violations

PR Context

During #11563 issues were uncovered, hence this PR.

PR Checklist

@ghost ghost assigned anmenaga Jan 13, 2020
@xtqqczze xtqqczze mentioned this pull request Jan 13, 2020
Merged
8 tasks
@TravisEz13
Copy link
Member
TravisEz13 commented Jan 14, 2020

Was this tested on Windows PowerShell?

@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned anmenaga Jan 14, 2020
TravisEz13
TravisEz13 requested changes Jan 14, 2020
View reviewed changes
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 14, 2020
@TravisEz13 TravisEz13 added the CL-BuildPackaging 8000 Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 14, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Jan 14, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 14, 2020
@TravisEz13 TravisEz13 merged commit ba9a7b1 into PowerShell:master Jan 15, 2020
@xtqqczze xtqqczze deleted the build.psm1 branch February 4, 2020 23:52
@ghost
Copy link
ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @TravisEz13 @anmenaga
0