8000 Update pester syntax to v4 by xtqqczze · Pull Request #11544 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Update pester syntax to v4 #11544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 11, 2020
Merged

Conversation

xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Jan 9, 2020

PR Summary

  • Update Pester tests to dashed v4 syntax
  • Capitalise 'Should' and parameters

PR Context

Pester documentation for 4.x recommends using Should -Be instead of Should Be syntax.

PR Checklist

@iSazonov
Copy link
Collaborator

@xtqqczze It is a huge PR. Please to split it on some small PR. It is easy to fix and review.

@xtqqczze xtqqczze force-pushed the update-pester-syntax branch from 01dbaea to c4de7ba Compare January 10, 2020 21:04
@xtqqczze xtqqczze changed the title [WIP]Update pester syntax Update pester syntax to v4 Jan 10, 2020
```powershell
$_ -ireplace '\s?\|\s?should\b',' | Should'
```
```powershell
$_ -ireplace '(\| Should) not\b','$1 -Not'
```
```powershell
$_ -ireplace '(\| Should(?: -Not)?) -?be\b','$1 -Be'
```
$_ -ireplace '(\| Should(?: -Not)?) -?beexactly\b','$1 -BeExactly'
```powershell
$_ -ireplace '(\| Should(?: -Not)?) -?begreaterthan\b','$1 -BeGreaterThan'
```
```powershell
$_ -ireplace '(\| Should(?: -Not)?) -Be\s\$?true\b','$1 -BeTrue'
```
```powershell
$_ -ireplace '(\| Should(?: -Not)?) -Be\s\$?false\b','$1 -BeFalse'
```
```powershell
$_ -ireplace '(\| Should(?: -Not)?)\s-?match\b','$1 -Match'
```
```powershell
$_ -ireplace '(\| Should(?: -Not)?)\s-?throw\b','$1 -Throw'
```
```powershell
$_ -ireplace '(\| Should(?: -Not)?)\s-?benullorempty\b','$1 -BeNullOrEmpty'
```
```powershell
$_ -ireplace '\s-because\b',' -Because'
```
@xtqqczze xtqqczze force-pushed the update-pester-syntax branch from c4de7ba to e829996 Compare January 11, 2020 13:09
@xtqqczze
Copy link
Contributor Author

@iSazonov Removed some commits and rebased, PR is ready for merge.

@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 11, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Jan 11, 2020
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Jan 11, 2020
@iSazonov iSazonov merged commit 7439833 into PowerShell:master Jan 11, 2020
@iSazonov
Copy link
Collaborator

@xtqqczze Thanks for your contribution!

@ghost
Copy link
ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze xtqqczze deleted the update-pester-syntax branch May 6, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Test Indicates that a PR should be marked as a test change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0