10BC0 Add script to rebuild component refs by TravisEz13 · Pull Request #11485 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add script to rebuild component refs #11485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 5 commits into from
Jan 4, 2020
Merged

Add script to rebuild component refs #11485

TravisEz13 merged 5 commits into from
Jan 4, 2020

Conversation

@TravisEz13
Copy link
Member
@TravisEz13 TravisEz13 commented Jan 3, 2020 •
edited
Loading

PR Summary

Add script to rebuild WIX component refs

PR Context

Someone (cc @SteveL-MSFT, @bergmeister), let the WIX file fragment be edited by hand and become corrupt.
This script examines the WXS fragment and looks for the corruption, fails the build, and outputs and correctly built WXS fragment.

Note, Please do not hand edit the files.wxs file. Always let the CI system, find the problems and fix them.
If you try to hand edit, you risk us not being able to issues a security patch if needed.

PR Checklist

@ghost ghost assigned daxian-dbw Jan 3, 2020
@TravisEz13
Copy link
Member Author
TravisEz13 commented Jan 3, 2020

This run produced the fixed wix file: https://dev.azure.com/powershell/PowerShell/_build/results?buildId=42371&view=artifacts&type=publishedArtifacts

adityapatwardhan
adityapatwardhan approved these changes Jan 3, 2020
View reviewed changes
@TravisEz13 TravisEz13 added this to the GA-consider milestone Jan 3, 2020
@daxian-dbw
Copy link
Member
daxian-dbw commented Jan 3, 2020

@TravisEz13 Can you please update the PR description to include some context information about this change?

@TravisEz13 TravisEz13 merged commit 2c0d68c into PowerShell:master Jan 4, 2020
@TravisEz13 TravisEz13 deleted the fix_msi branch January 4, 2020 20:14
@bergmeister
Copy link
Contributor
bergmeister commented Jan 4, 2020

I am missing the context as well. Usually, I've used the auto-generated WiX file that Start-PSPackage produced when updates to DLLs were required due to a newer .Net Core version. Since the script does XML parsing to check the contents anyway, I don't understand what you mean by 'corrupted'

@TravisEz13
Copy link
Member Author
TravisEz13 commented Jan 7, 2020

@bergmeister is you used the autogenerated files, then you are not the cause. Someone did not and the ComponentGroup section of the file did not contain all the updated components.

@TravisEz13
Copy link
Member Author
TravisEz13 commented Jan 7, 2020 •
edited
Loading

This happened in the fork we used to update to .NET Core 3.0. We squash merged that fork, so.... I cannot tell where exactly the issue occurred.
It took more time to figure out what was wrong than to fix it. So, the problem itself wasn't that bad. It's just the fact that the problem was unexpected and we were not looking for it (as we expect people to use the auto-generated wxs files)

daxian-dbw pushed a commit that referenced this pull request Jan 10, 2020
@TravisEz13 @daxian-dbw
Add script to rebuild WIX component refs (#11485)
4af8b16 
* Add script to rebuild component refs

* fix type

* fix document we get componentGroup from

* update files.wxs

* fix dependencies
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 15, 2020
@ghost
Copy link
ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@daxian-dbw daxian-dbw

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log MustHave

Projects

None yet

Milestone

7.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

4 participants

@TravisEz13 @daxian-dbw @bergmeister @adityapatwardhan
0