Re-balance CI tests #11420
Re-balance CI tests #11420
Conversation
ecce392 to
1e806eb
Compare
10BC0
1e806eb to
e6f48f4
Compare
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-windows
Tests for Get-ComputerInfo: Ensure Type returned.Verify type returned by Get-ComputerInfo
Expected the value to have type [Microsoft.PowerShell.Commands.ComputerInfo] or any of its subtypes, but got @{BiosCaption=Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz} with type [PSCustomObject].
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\Get-ComputerInfo.Tests.ps1: line 1011
1011: $computerInfo | Should -BeOfType 'Microsoft.PowerShell.Commands.ComputerInfo'db545b7 to
1868802
Compare
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-windows
Basic FileSystem Provider Tests.Appx path.Can get an appx package item
Cannot find path 'TestDrive:\Calculator.exe' because it does not exist.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 292
292: Get-Item $pkgDir\Calculator.exe -ErrorAction Stop | Should -BeOfType [System.IO.FileInfo]
cca5a81 to
c986694
Compare
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-linux
Test-Connection.TraceRoute.returns false without error if MaxHops is exceeded during -Traceroute -Quiet
Missing an argument for parameter 'TimeoutSeconds'. Specify a parameter of type 'System.Int32' and try again.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 278
278: Test-Connection 8.8.8.8 -Traceroute -MaxHops 2 -TimeoutSeconds -Quiet | Should -BeFalse
There was a problem hiding this comment.
@iSazonov, your last commit had 2 failures in PowerShell-CI-windows
Basic FileSystem Provider Tests.Appx path.Can get an appx package item
Cannot find path 'TestDrive:\Calculator.exe' because it does not exist.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 292
292: Get-Item $pkgDir\Calculator.exe -ErrorAction Stop | Should -BeOfType [System.IO.FileInfo]
Test-Connection.TraceRoute.returns false without error if MaxHops is exceeded during -Traceroute -Quiet
Missing an argument for parameter 'TimeoutSeconds'. Specify a parameter of type 'System.Int32' and try again.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\Test-Connection.Tests.ps1: line 278
278: Test-Connection 8.8.8.8 -Traceroute -MaxHops 2 -TimeoutSeconds -Quiet | Should -BeFalse
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-macos
Test-Connection.TraceRoute.returns false without error if MaxHops is exceeded during -Traceroute -Quiet
Missing an argument for parameter 'TimeoutSeconds'. Specify a parameter of type 'System.Int32' and try again.
at <ScriptBlock>, /Users/runner/runners/2.163.1/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 278
278: Test-Connection 8.8.8.8 -Traceroute -MaxHops 2 -TimeoutSeconds -Quiet | Should -BeFalse
c986694 to
99d4b7e
Compare
There was a problem hiding this comment.
@iSazonov, your last commit had 2 failures in PowerShell-CI-windows
Basic FileSystem Provider Tests.Appx path.Can get an appx package item
Cannot find path 'TestDrive:\Calculator.exe' because it does not exist.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 292
292: Get-Item $pkgDir\Calculator.exe -ErrorAction Stop | Should -BeOfType [System.IO.FileInfo]
Test-Connection.TraceRoute.returns false without error if MaxHops is exceeded during -Traceroute -Quiet
Missing an argument for parameter 'TimeoutSeconds'. Specify a parameter of type 'System.Int32' and try again.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\Test-Connection.Tests.ps1: line 278
278: Test-Connection 8.8.8.8 -Traceroute -MaxHops 2 -TimeoutSeconds -Quiet | Should -BeFalse
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-linux
Test-Connection.TraceRoute.returns false without error if MaxHops is exceeded during -Traceroute -Quiet
Missing an argument for parameter 'TimeoutSeconds'. Specify a parameter of type 'System.Int32' and try again.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 278
278: Test-Connection 8.8.8.8 -Traceroute -MaxHops 2 -TimeoutSeconds -Quiet | Should -BeFalse
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-macos
Test-Connection.TraceRoute.returns false without error if MaxHops is exceeded during -Traceroute -Quiet
Missing an argument for parameter 'TimeoutSeconds'. Specify a parameter of type 'System.Int32' and try again.
at <ScriptBlock>, /Users/runner/runners/2.163.1/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 278
278: Test-Connection 8.8.8.8 -Traceroute -MaxHops 2 -TimeoutSeconds -Quiet | Should -BeFalse
99d4b7e to
dbe38e6
Compare
dbe38e6 to
9d83d30
Compare
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By CustomPipeName.Can enter, exit, and re-enter using CustomPipeName
Expected $true, because The script was able to re-enter another process and grab the pipe of '4pzbeujh.2it'., but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 186
186: Should -BeTrue -Because "The script was able to re-enter another process and grab the pipe of '$pipeName'."|
@SteveL-MSFT @vexx32 I reverted last commit because it cause the test fail #11420 (review) that looks very amizing. |
|
Can we split this into two PRs? One for the tests fixes and refactoring and one for the rebalancing? |
65f361e to
8454725
Compare
8454725 to
4b56fee
Compare
@TravisEz13 There are only two commits/files for explicit rebalancing where I replace CI tag with Feature one - Jobs and HelpSystemOnline. I don't see any value to move them to new PR. I guess you ask about first commit "Correct pwsh run" that single looks like unrelated change. |
4b56fee to
3b60f3b
Compare
This reverts commit 9d83d30377c660fdeabbc4e18a7d3a20e81c0d48.
|
🎉 Handy links: |
PR Summary
Re-balance tests to reduce CI times for PRs.
Better review commit by commit.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.