Make null member access tests as string to avoid parsing errors #11385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
approved these changes
Dec 17, 2019
daxian-dbw
reviewed
Dec 17, 2019
daxian-dbw
approved these changes
Dec 20, 2019
Member
There was a problem hiding this comment.
Looks good. But are you going to make similar changes to the NullConditionalOperator tests in Parser.Tests.ps1 and the tabcompletion test file?
Member
Author
|
@daxian-dbw - Added Parsing tests in the PR. |
PoshChan
reviewed
Dec 20, 2019
Member
Author
|
@PoshChan please retry linux |
Collaborator
|
@adityapatwardhan, successfully started retry of |
daxian-dbw
approved these changes
Dec 20, 2019
|
Hello @adityapatwardhan! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
daxian-dbw
pushed a commit
that referenced
this pull request
Jan 10, 2020
* Make null member access tests as string to avoid parsing errors * Add PSNullConditionalOperators feature to testmetadata.json * Add Parsing tests to be skipped * Add tabcompletion tests
|
🎉 Handy links: |
22 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #11354
PSNullConditionalOperatorsfeature is disabled by default. Hence it causes parsing error when tests are run. This PR converts the tests into here strings and executes them if the feature is enabled.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.