8000 Update hosting tests to use the SDK version from the build property by adityapatwardhan · Pull Request #11368 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Update hosting tests to use the SDK version from the build property #11368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 1 commit into from
Dec 18, 2019
Merged

Update hosting tests to use the SDK version from the build property #11368

anmenaga merged 1 commit into from
Dec 18, 2019

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Dec 17, 2019 •
edited
Loading

PR Summary

The SDK tests need to use the PS Version of the release under proces. By passing it as a build property we can dynamically change the value. We get the value in the release pipeline through the release metadata json.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Dec 17, 2019
PoshChan
PoshChan reviewed Dec 17, 2019
View reviewed changes
@adityapatwardhan adityapatwardhan added this to the GA-consider milestone Dec 17, 2019
PoshChan
PoshChan reviewed Dec 17, 2019
View reviewed changes
PoshChan
PoshChan reviewed Dec 17, 2019
View reviewed changes
@daxian-dbw daxian-dbw closed this Dec 17, 2019
@daxian-dbw daxian-dbw reopened this Dec 17, 2019
@anmenaga anmenaga added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Dec 18, 2019
@anmenaga anmenaga merged commit a24a5c7 into PowerShell:master Dec 18, 2019
daxian-dbw pushed a commit that referenced this pull request Jan 10, 2020
@adityapatwardhan @daxian-dbw
Update hosting tests to use the SDK version from the build property (#…
6af3f9e 
…11368)
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@ghost
Copy link
ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

2 more reviewers

@PoshChan PoshChan PoshChan left review comments

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

4 participants

@adityapatwardhan @anmenaga @PoshChan @daxian-dbw
0