Add retry to Enter-PSHostProcess test #11360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
Dec 18, 2019
| $ps.AddScript('$pid').Invoke() | Should -Be $pwshId | ||
| $ps.AddScript('$pid') | ||
|
|
||
| [int]$retry = 0 |
Member
There was a problem hiding this comment.
Can we use Wait-UntilTrue from HelpersCommon.psm1?
Member
There was a problem hiding this comment.
If not, maybe add a retry function on HelpersCommon.
Member
Author
There was a problem hiding this comment.
I worked out a Invoke-ScriptBlockWithRetry function, but it doesn't save much and makes the code harder to understand since I need to pass two types of information back.
adityapatwardhan
approved these changes
Dec 20, 2019
daxian-dbw
pushed a commit
that referenced
this pull request
Jan 10, 2020
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Been seeing this test fail in CI on occasion. Have it retry 5 times and also write out a verbose message if the runspace state is not valid to see why it fails.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.