Update calculation of char width to respect CJK chars correctly #11262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoshChan
reviewed
Dec 4, 2019
Member
Author
|
@PoshChan please retry linux |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
iSazonov
reviewed
Dec 4, 2019
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleControl.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
@SteveL-MSFT Is milestone 7.rc1 ok? |
Member
Author
|
@iSazonov the risk of this change is low, we can take it for rc1 |
iSazonov
approved these changes
Dec 5, 2019
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Need to fix in two places to correctly calculate length of string in buffer cells if the string contains double wide chars. When used interactively, the console host does the calculation, so need to make a method that was only used on Windows available for all platforms and use it to calculate length in buffer cells. When formatting goes through
Out-String, then it uses the default length calculation in line output so that needed to use the same method. Since the code is in two different assemblies, there is two copies of the same code.PR Context
Fix #11232
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.