8000 Update ADOPTERS.md by edyoung · Pull Request #11261 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@edyoung
Copy link
Contributor
@edyoung edyoung commented Dec 3, 2019

PR Summary

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Dec 3, 2019
@edyoung edyoung requested a review from SteveL-MSFT December 3, 2019 23:27
@SteveL-MSFT
Copy link
Member

@edyoung You'll need to fix the Codacy issue which is to indent you bullet by 2 spaces. Also, @TravisEz13 we should consider updating .spelling to ignore this specific file since we're askinging the adopter to submit the PR and we'll likely hit many new words.

Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Codacy issue

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 4, 2019
Co-Authored-By: Steve Lee <slee@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 4, 2019
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 4, 2019
Co-Authored-By: Steve Lee <slee@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 4, 2019
Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the Codacy markdown rule seems incorrect. It's complaining about the spacing between the * and the content.

We can debate the .spelling separate from this PR

@TravisEz13
Copy link
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator
PoshChan commented Dec 4, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13
Copy link
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator
PoshChan commented Dec 4, 2019

@TravisEz13, 8000 this is the reminder you requested 1 hour ago

@iSazonov
Copy link
Collaborator
iSazonov commented Dec 5, 2019

It would be nice to have an soft integrations with adopters CIs so that we could see their daily status for latest pwsh builds - this helps us to discover, track and resolve breaking changes for tools (now we have only formal check boxes in PR template).

@TravisEz13
Copy link
Member

@iSazonov Please file a new issues for new enhancements rather than commenting in an existing PR/Issue

@TravisEz13 TravisEz13 merged commit 1e7ab88 into master Dec 6, 2019
@TravisEz13 TravisEz13 deleted the edyoung-patch-1 branch December 6, 2019 19:47
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.1 milestone Jan 9, 2020
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 24, 2020
@ghost
Copy link
ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

0