-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update ADOPTERS.md #11261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ADOPTERS.md #11261
Conversation
|
@edyoung You'll need to fix the Codacy issue which is to indent you bullet by 2 spaces. Also, @TravisEz13 we should consider updating .spelling to ignore this specific file since we're askinging the adopter to submit the PR and we'll likely hit many new words. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address Codacy issue
Co-Authored-By: Steve Lee <slee@microsoft.com>
Co-Authored-By: Steve Lee <slee@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the Codacy markdown rule seems incorrect. It's complaining about the spacing between the * and the content.
We can debate the .spelling separate from this PR
|
@PoshChan Please remind me in 1 hour |
|
@TravisEz13, this is the reminder you requested 1 hour ago |
|
@PoshChan Please remind me in 1 hour |
|
@TravisEz13, 8000 this is the reminder you requested 1 hour ago |
|
It would be nice to have an soft integrations with adopters CIs so that we could see their daily status for latest pwsh builds - this helps us to discover, track and resolve breaking changes for tools (now we have only formal check boxes in PR template). |
|
@iSazonov Please file a new issues for new enhancements rather than commenting in an existing PR/Issue |
|
🎉 Handy links: |
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.