8000 Fix regression in Get-PSCallStack by iSazonov · Pull Request #11210 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix regression in Get-PSCallStack #11210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 4 commits into from
Dec 2, 2019
Merged

Fix regression in Get-PSCallStack #11210

adityapatwardhan merged 4 commits into from
Dec 2, 2019

Conversation

@iSazonov
Copy link
Collaborator
@iSazonov iSazonov commented Nov 28, 2019 •
edited
Loading

PR Summary

Fix #11208

PR Context

The regression comes from #6950

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 28, 2019
@iSazonov iSazonov added this to the 7.0-Consider milestone Nov 28, 2019
@iSazonov iSazonov force-pushed the fix-typetable-emptystring branch from afc3e2b to 6e5daaa Compare November 28, 2019 07:53
BrucePay
BrucePay reviewed Nov 28, 2019
View reviewed changes
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-PSCallStack.Tests.ps1 Outdated
}

It "Get-PSCallStack returns Arguments" {
& { (Get-PSCallStack)[0].Arguments } 'foo' | Should -Match 'foo'
Copy link
Collaborator
@BrucePay BrucePay Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test for the case where the scriptblock has formal parameters:

 & { param ($x)  (Get-PSCallStack)[0].Arguments } 'foo'

and another where multiple arguments are passed to the scriptblock:

 & { (Get-PSCallStack)[0].Arguments } 'foo'  'bar'

Copy link
Collaborator Author
@iSazonov iSazonov Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@adityapatwardhan adityapatwardhan merged commit 2ee1760 into PowerShell:master Dec 2, 2019
@iSazonov iSazonov deleted the fix-typetable-emptystring branch December 3, 2019 03:20
@TravisEz13 TravisEz13 removed this from the rc.1-consider milestone Dec 4, 2019
@TravisEz13 TravisEz13 added this to the rc.1-approved milestone Dec 4, 2019
TravisEz13 pushed a commit that referenced this pull request Dec 4, 2019
@iSazonov @TravisEz13
Fix regression in Get-PSCallStack (#11210)
0de578c
@TravisEz13 TravisEz13 modified the milestones: rc.1-approved, 7.0.0-rc.1 Dec 4, 2019
@ghost
Copy link
ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 16, 2019
Closed
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+2 more reviewers

@BrucePay BrucePay BrucePay left review comments

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

@TravisEz13 TravisEz13

@anmenaga anmenaga

@adityapatwardhan adityapatwardhan

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

Get-PSCallStack's Arguments script property contains no useful information

7 participants

@iSazonov @BrucePay @adityapatwardhan @PoshChan @daxian-dbw @TravisEz13 @anmenaga
0