Disable autoloading PSScheduledJob module from -Job cmdlets #11194
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
approved these changes
Nov 26, 2019
Collaborator
|
I am NOT overjoyed with this being pushed out to 7.1. The experience of Preview.6 is, in my mind, not really acceptable. I favour a working solution in PWSH 7.0 RTM. |
Collaborator
|
@doctordns looks like it's targeted for 7.0 RC1, so it should definitely be in the 7.0 release as well. 🙂 |
Collaborator
Collaborator
|
I would assume it should already be in the daily builds, since it was merged to the master branch a week or so ago. 🙂 |
Member
|
@vexx32, @doctordns master branch is now 7.1, we selectively triage and approve merged PRs to be taken to rc.1 branch. This one should be in rc.1 |
Collaborator
|
@SteveL-MSFT |
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently all
*-Jobcmdlets try to autoloadPSScheduledJobmodule that is not PS-Core compatible, so this autoload quietly fails, so it is a waste of resources.Furthermore, this autoload of
PSScheduledJobmodule creates bad user experience whenWinCompatis enabled (see issue #11164 ).Disabling this code provides solution to both issues.
Fix #11164
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.