8000 Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc. by brendandburns · Pull Request #11155 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc. #11155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Nov 26, 2019
Merged

Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc. #11155

TravisEz13 merged 1 commit into from
Nov 26, 2019

Conversation

@brendandburns
Copy link
Contributor
@brendandburns brendandburns commented Nov 22, 2019

PR Summary

Improve detection of Ubuntu-based systems

PR Context

There are lots of Ubuntu deriviatives out there, but they all are based on Ubuntu and thus supported by this script. Improve detection of such distros using the lsb_release tool.

PR Checklist

TravisEz13
TravisEz13 reviewed Nov 22, 2019
View reviewed changes
TravisEz13
TravisEz13 requested changes Nov 22, 2019
View reviewed changes
Copy link
Member
@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 22, 2019
@TravisEz13 TravisEz13 self-assigned this Nov 22, 2019
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 25, 2019
@brendandburns
Copy link
Contributor Author
brendandburns commented Nov 25, 2019

Comment addressed. Please re-check.

@brendandburns
Copy link
Contributor Author
brendandburns commented Nov 26, 2019

fwiw, the CodeFactor failures don't appear to be related to this change. Do I need to rebase?

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Nov 26, 2019

@brendanburns CodeFactor isn't a merge blocker. Since you looked at the failures and they are not related to your change, you can ignore. Looks good, thanks for your contribution!

@TravisEz13 TravisEz13 merged commit 2a76aa1 into PowerShell:master Nov 26, 2019
@daxian-dbw daxian-dbw added this to the GA-approved milestone Jan 9, 2020
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 9, 2020
daxian-dbw pushed a commit that referenced this pull request Jan 10, 2020
@brendandburns @daxian-dbw
Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc (#…
d45b77f 
…11155)
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@ghost
Copy link
ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

5 participants

@brendandburns @SteveL-MSFT @TravisEz13 @daxian-dbw @brendanburns
0