8000 Fix setting original path of filesystem object to not have extra trailing slash by SteveL-MSFT · Pull Request #10959 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix setting original path of filesystem object to not have extra trailing slash #10959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Nov 2, 2019
Merged

Fix setting original path of filesystem object to not have extra trailing slash #10959

iSazonov merged 2 commits into from
Nov 2, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 31, 2019 •
edited
Loading

PR Summary

In the method to build the correct casing of a path, it handled the root of the drive, but later in the loop since the original path had a trailing slash, it added another one. Fix is to detect if the resulting path already has a trailing slash and don't add it.

PR Context

Fix #10956

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from iSazonov October 31, 2019 21:35
@SteveL-MSFT SteveL-MSFT requested a review from anmenaga as a code owner October 31, 2019 21:35
@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 31, 2019

Codacy uses PSSA which misidentified ternary operator as cmdlet. I opened PowerShell/PSScriptAnalyzer#1362

iSazonov
iSazonov reviewed Nov 1, 2019
View reviewed changes
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 1, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Nov 1, 2019
@iSazonov iSazonov merged commit 4b84627 into PowerShell:master Nov 2, 2019
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 21, 2019
Closed
@SteveL-MSFT SteveL-MSFT deleted the root-dir branch June 6, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

Get-Item with a drive's root dir stringifies incorrectly

2 participants

@SteveL-MSFT @iSazonov
0