8000 Make `ConvertTo-Json` treat `[AutomationNull]::Value` and `[NullString]::Value` as $null by daxian-dbw · Pull Request #10957 · PowerShell/PowerShell · GitHub 8000
[go: up one dir, main page]
Skip to content

Make ConvertTo-Json treat [AutomationNull]::Value and [NullString]::Value as $null #10957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 3 commits into from
Nov 5, 2019
Merged

Make ConvertTo-Json treat [AutomationNull]::Value and [NullString]::Value as $null #10957

anmenaga merged 3 commits into from
Nov 5, 2019

Conversation

@daxian-dbw
Copy link
Member
@daxian-dbw daxian-dbw commented Oct 31, 2019 •
edited
Loading

PR Summary

Fix #9231

Make ConvertTo-Json treat [AutomationNull]::Value and [NullString]::Value as $null

This is a breaking change given the fact that [AutomationNull]::Value and [NullString]::Value are deserailized into an empty object {} today and will be null after this change.
However, it's hard to believe anyone is depending on the current wrong behavior.

PR Checklist

@daxian-dbw daxian-dbw added the Breaking-Change breaking change that may affect users label Oct 31, 2019
anmenaga
anmenaga reviewed Oct 31, 2019
View reviewed changes
@daxian-dbw
Copy link
Member Author
daxian-dbw commented Nov 4, 2019

Rebased to resolve conflicts.

@daxian-dbw
Copy link
Member Author
daxian-dbw commented Nov 5, 2019

@PoshChan Please retry static

@daxian-dbw
Copy link
Member Author
daxian-dbw commented Nov 5, 2019

@PoshChan Please retry linux

@PoshChan
Copy link
Collaborator
PoshChan commented Nov 5, 2019

@daxian-dbw, successfully started retry of PowerShell-CI-Linux

@PoshChan
Copy link
Collaborator
PoshChan commented Nov 5, 2019

@daxian-dbw, successfully started retry of PowerShell-CI-static-analysis

@anmenaga anmenaga added this to the 7.0.0-preview.6 milestone Nov 5, 2019
@anmenaga anmenaga added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 5, 2019
@anmenaga anmenaga merged commit 518a479 into PowerShell:master Nov 5, 2019
@daxian-dbw daxian-dbw deleted the json branch November 5, 2019 23:58
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

+2 more reviewers

@PoshChan PoshChan PoshChan left review comments

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

Breaking-Change breaking change that may affect users CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

ConvertTo-Json unexpectedly serializes AutomationValue.Null as an empty object, not null

4 participants

@daxian-dbw @PoshChan @SteveL-MSFT @anmenaga
0