8000 Fix `Start-Job -WorkingDirectory` with whitespace by SteveL-MSFT · Pull Request #10951 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix Start-Job -WorkingDirectory with whitespace #10951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 4 commits into from
Nov 1, 2019
Merged

Fix Start-Job -WorkingDirectory with whitespace #10951

anmenaga merged 4 commits into from
Nov 1, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 30, 2019 •
edited
Loading

PR Summary

Start-Job -WorkingDirectory fails if the path contains whitespace as the argument isn't quoted. Fix is to add quotes around the path.

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from anmenaga October 30, 2019 23:44
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 31, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Oct 31, 2019
@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 31, 2019

@PoshChan please retry linux

@PoshChan
Copy link
Collaborator
PoshChan commented Oct 31, 2019

@SteveL-MSFT, successfully started retry of PowerShell-CI-Linux

@anmenaga anmenaga merged commit 4b9c2b2 into PowerShell:master Nov 1, 2019
@mklement0 mklement0 mentioned this pull request Nov 12, 2019
Merged
14 tasks
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@SteveL-MSFT SteveL-MSFT deleted the start-job-wd branch June 6, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

+2 more reviewers

@PoshChan PoshChan PoshChan left review comments

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveL-MSFT @PoshChan @anmenaga @iSazonov
0