10BC0 handle IO Exception as non-terminating by SteveL-MSFT · Pull Request #10950 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

handle IO Exception as non-terminating #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 1 commit into from
Nov 1, 2019
Merged

handle IO Exception as non-terminating #10950

adityapatwardhan merged 1 commit into from
Nov 1, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 30, 2019 •
edited
Loading

PR Summary

FileSystemProvider CopyItem was only handling UnauthorizedAccessException. However, if a file is in use and can't be overwritten it's an IOException which is then unhandled and stops a recursive copy. Fix is to catch IOException and emit an ErrorRecord and continue.

PR Context

Fix #2474

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from anmenaga as a code owner October 30, 2019 21:34
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 30, 2019
@adityapatwardhan adityapatwardhan merged commit a3d73d7 into PowerShell:master Nov 1, 2019
@adityapatwardhan adityapatwardhan added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 1, 2019
@adityapatwardhan adityapatwardhan added this to the 7.0.0-preview.6 milestone Nov 1, 2019
@SteveL-MSFT SteveL-MSFT deleted the copy-item-inuse branch November 1, 2019 17:19
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 21, 2019
Closed
@unfurl-links unfurl-links bot mentioned this pull request Mar 27, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

copy-item does not respect -ErrorAction SilentlyContinue if file is in use

2 participants

@SteveL-MSFT @adityapatwardhan
0