8000 Handle case where Host may not return Rows or Cols of screen by SteveL-MSFT · Pull Request #10938 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Handle case where Host may not return Rows or Cols of screen #10938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 2 commits into from
Oct 30, 2019
Merged

Handle case where Host may not return Rows or Cols of screen #10938

anmenaga merged 2 commits into from
Oct 30, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 29, 2019 •
edited
Loading

PR Summary

In the case where the Host doesn't implement WindowSize so that Rows and Cols can be returned, this is handled locally. But if used over interactive remote session, the remoting layer throws a remoting exception. To handle this case, catch any exception trying to retrieve those values and use a default value so that formatting still renders. The previous fix for this was too specific in the Exceptions caught that it didn't catch a remoting Exception.

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from PaulHigin October 29, 2019 22:29
rjmholt
rjmholt reviewed Oct 29, 2019
View reviewed changes
@SteveL-MSFT SteveL-MSFT changed the title Handle case where Host may not return Rows or Cols of screen WIP: Handle case where Host may not return Rows or Cols of screen Oct 29, 2019
@SteveL-MSFT SteveL-MSFT changed the title WIP: Handle case where Host may not return Rows or Cols of screen Handle case where Host may not return Rows or Cols of screen Oct 30, 2019
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 30, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Oct 30, 2019
@anmenaga anmenaga merged commit 00f41a7 into PowerShell:master Oct 30, 2019
@SteveL-MSFT SteveL-MSFT deleted the format-table-remoting branch October 30, 2019 19:57
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@rjmholt rjmholt rjmholt left review comments

@PoshChan PoshChan PoshChan left review comments

@anmenaga anmenaga anmenaga approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

6 participants

@SteveL-MSFT @rjmholt @anmenaga @PaulHigin @PoshChan @iSazonov
0