8000 Fix use of accent colors for hosts that don't support them by SteveL-MSFT · Pull Request #10937 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix use of accent colors for hosts that don't support them #10937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 2 commits into from
Oct 30, 2019
Merged

Fix use of accent colors for hosts that don't support them #10937

anmenaga merged 2 commits into from
Oct 30, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 29, 2019 •
edited
Loading

PR Summary

For existing hosts that don't expose the new Accent colors, need to default to a different color.

PR Checklist

TylerLeonhardt
TylerLeonhardt approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member
@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 30, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Oct 30, 2019
@anmenaga anmenaga merged commit edda43d into PowerShell:master Oct 30, 2019
@SteveL-MSFT SteveL-MSFT deleted the errorview-host branch October 30, 2019 19:57
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveL-MSFT @TylerLeonhardt @anmenaga @iSazonov
0