Enable build of x86 MSIX package #10934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Have you tested the new build? |
Member
Author
|
Built it locally, signed, installed and confirm it's x86. Also confirmed that you can't have both x64 and x86 msix installed at same time (cc @rjmholt) |
Member
|
@SteveL-MSFT Can you test the actual new build? Setup time with me if you need help |
Member
|
doesn't have the latest changes from the other branch |
Member
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@TravisEz13, this is the reminder you requested 1 hour ago |
TravisEz13
approved these changes
Nov 5, 2019
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable build of x86 MSIX package
PR Summary
We should support x86 architecture for MSIX package. Tooling already supports building, just need to publish in our release pipeline.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.