8000 Add back `Update-List` command by SteveL-MSFT · Pull Request #10922 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add back Update-List command #10922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 4 commits into from
Oct 30, 2019
Merged

Add back Update-List command #10922

anmenaga merged 4 commits into from
Oct 30, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 28, 2019 •
edited
Loading

PR Summary

Re-enable Update-List cmdlet bringing parity with WinPS5.1. Added tests.

PR Checklist

@SteveL-MSFT SteveL-MSFT mentioned this pull request Oct 28, 2019
Closed
10 tasks
@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 29, 2019

@sdwheeler do you have an updated fwlink for this cmdlet?

@sdwheeler
Copy link
Collaborator
sdwheeler commented Oct 29, 2019

@SteveL-MSFT https://go.microsoft.com/fwlink/?linkid=2109383

anmenaga
anmenaga approved these changes Oct 29, 2019
View reviewed changes
Copy link
@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any info on why this cmdlet was removed originally?

@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 29, 2019

I don't know why it was originally removed since it should have been compatible since PSCore6. I don't find this cmdlet particularly useful (since you can just call the .NET API in PSScript), but a search on GitHub shows some scripts use it, so we should add it back for parity with WinPS.

@anmenaga anmenaga added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 30, 2019
@anmenaga anmenaga merged commit 0b12ea0 into PowerShell:master Oct 30, 2019
@anmenaga anmenaga added this to the 7.0.0-preview.6 milestone Oct 30, 2019
@SteveL-MSFT SteveL-MSFT deleted the update-list branch November 2, 2019 04:55
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

2 more reviewers

@PoshChan PoshChan PoshChan left review comments

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveL-MSFT @sdwheeler @anmenaga @PoshChan
0