8000 `Install-Powershell.ps1`: Add parameter to use MSI installation by MJECloud · Pull Request #10921 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Install-Powershell.ps1: Add parameter to use MSI installation #10921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Oct 30, 2019
Merged

Install-Powershell.ps1: Add parameter to use MSI installation #10921

TravisEz13 merged 1 commit into from
Oct 30, 2019

Conversation

@MJECloud
Copy link
Contributor
@MJECloud MJECloud commented Oct 28, 2019

PR Summary

Added Parameter -AddExplorerContextMenu and -EnablePSRemoting to use MSI properties.
Documented here

PR Context

PR Checklist

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 29, 2019

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator
PoshChan commented Oct 29, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 29, 2019

looks like this needs to be rebased to get the tests to pass.

@MJECloud
Copy link
Contributor Author
MJECloud commented Oct 30, 2019

Rebased to resolve the conflicts

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 30, 2019

The rebase is bad... I'll try to fix it. Please don't do any changes to your branch.

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 30, 2019

I fixed the rebase. If you make changes, be sure to fetch the new history in your branch first.

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 30, 2019

@PoshChan Please remind me in 1 hour

@MJECloud
Copy link
Contributor Author
MJECloud commented Oct 30, 2019

Oh i'm sorry for messing it up.
Thanks for fixing, will remember it next time :)

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 30, 2019

Here is the command I ran, after I reset your branch to before your merge.
~/git/powershell> git rebase master-upstream pr/MJECloud/10921

@TravisEz13 TravisEz13 changed the title Install-Powershell.ps1: Add parameter to use MSI installation properties Install-Powershell.ps1: Add parameter to use MSI installation Oct 30, 2019
@TravisEz13 TravisEz13 merged commit 96e2a2e into PowerShell:master Oct 30, 2019
@PoshChan
Copy link
Collaborator
PoshChan commented Oct 30, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@PaulHigin PaulHigin added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Nov 19, 2019
@PaulHigin PaulHigin added this to the 7.0.0-preview.6 milestone Nov 19, 2019
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

5 participants

@MJECloud @TravisEz13 @PoshChan @PaulHigin @mjegob
0