8000 Set working directory to current directory in Start-Job by iSazonov · Pull Request #10920 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Set working directory to current directory in Start-Job #10920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Oct 30, 2019
Merged

Set working directory to current directory in Start-Job #10920

TravisEz13 merged 1 commit into from
Oct 30, 2019

Conversation

@iSazonov
Copy link
Collaborator
@iSazonov iSazonov commented Oct 28, 2019 •
edited
Loading

PR Summary

As approved by PowerShell-Committee in #10673 set a working directory to current directory in Start-Job cmdlet.

PR Context

PR Checklist

@iSazonov iSazonov added Committee-Reviewed PS-Committee has reviewed this and made a decision CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Oct 28, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Oct 28, 2019
@iSazonov iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Oct 28, 2019
@iSazonov
Copy link
Collaborator Author
iSazonov commented Oct 28, 2019 •
edited
Loading

@rjmholt @TylerLeonhardt I hope this doesn't break any tool. Can you confirm?

@TylerLeonhardt
Copy link
Member
TylerLeonhardt commented Oct 28, 2019

I hope this doesn't break any tool

The PowerShell extension doesn't use Start-Job for anything and this wouldn't effect EditorSyntax since the syntax isn't changing.

I'm not 100% sure but doubt that PSScriptAnalyzer would be affected because I don't see why it would use Start-Job when it's a binary module.

SteveL-MSFT
SteveL-MSFT approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Oct 28, 2019

@PoshChan please retry static

@PoshChan
Copy link
Collaborator
PoshChan commented Oct 28, 2019

@SteveL-MSFT, successfully started retry of PowerShell-CI-static-analysis

PaulHigin
PaulHigin approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor
@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov removed the Documentation Needed in this repo Documentation is needed in this repo label Oct 28, 2019
@iSazonov iSazonov mentioned this pull request Oct 29, 2019
Closed
10 tasks
@TravisEz13 TravisEz13 merged commit 46957e5 into PowerShell:master Oct 30, 2019
@iSazonov iSazonov deleted the set-start-job-pwd branch October 31, 2019 03:01
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@iSazonov iSazonov mentioned this pull request Aug 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

@rjmholt rjmholt Awaiting requested review from rjmholt

+2 more reviewers

@PoshChan PoshChan PoshChan left review comments

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

6 participants

@iSazonov @TylerLeonhardt @SteveL-MSFT @PoshChan @PaulHigin @TravisEz13
0