10BC0 Add basic examples for `install-powershell.ps1` by kilasuit · Pull Request #10914 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@kilasuit
Copy link
Collaborator
@kilasuit kilasuit commented Oct 27, 2019

Adds some basic details for install-powershell.ps1 script

Fixes #10911

PR Summary

Adds some basic details to install-powershell-readme.md for the install-powershell.ps1 script

PR Context

PR Checklist

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 27, 2019
@TravisEz13 TravisEz13 self-assigned this Oct 27, 2019
@TravisEz13 TravisEz13 added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Oct 27, 2019
@TravisEz13 TravisEz13 added this to the 7.0.0-preview.6 milestone Oct 27, 2019
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 27, 2019
Adds some basic details for install-powershell.ps1 script
@SteveL-MSFT
Copy link
Member

@kilasuit looks like you amended your commit rather than push a new commit? This makes it hard to see what changed. In general, you should just push new commits. When we merge, it'll be squashed.

@kilasuit
Copy link
Collaborator Author

@SteveL-MSFT - noted your comment and will remember this in future as I have a habit of rebasing and rewriting commit history

@TravisEz13
Copy link
Member

retried link verification

@TravisEz13
Copy link
Member

@PoshChan please remind me in 1 hour

@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13
Copy link
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13 TravisEz13 changed the title add basic info for install-powershell.ps1 fixes #10911 Add basic examples for install-powershell.ps1 Oct 30, 2019
@TravisEz13 TravisEz13 merged commit 7b7fb0e into PowerShell:master Oct 30, 2019
@kilasuit kilasuit deleted the patch-2 branch October 31, 2019 19:20
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install-powershell-readme.md doesn't contain any instructions to install from PowerShell

5 participants

0