8000 During Tab Completion, skip file if can't read file attributes by SteveL-MSFT · Pull Request #10910 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

During Tab Completion, skip file if can't read file attributes #10910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Oct 28, 2019
Merged

During Tab Completion, skip file if can't read file attributes #10910

iSazonov merged 1 commit into from
Oct 28, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 27, 2019 •
edited
Loading

PR Summary

During tab completion, while enumerating files, if the file attributes can't be read, just ignore error and skip that file. Previously, the file access exception wasn't handled and tab completion completely failed without returning any results.

PR Context

Fix #7648

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from rjmholt October 27, 2019 03:37
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 28, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Oct 28, 2019
@iSazonov iSazonov merged commit 2746cb7 into PowerShell:master Oct 28, 2019
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 21, 2019
Closed
@SteveL-MSFT SteveL-MSFT deleted the file-tabcomplete branch June 6, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov < 625B /span> iSazonov approved these changes

@rjmholt rjmholt Awaiting requested review from rjmholt

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

Tab completion under /mnt/c stymied by hiberfil.sys

2 participants

@SteveL-MSFT @iSazonov
0