Add back Clear-RecycleBin for Windows
#10909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
iSazonov
reviewed
Oct 27, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/ClearRecycleBinCommand.cs
Show resolved
Hide resolved
iSazonov
approved these changes
Oct 27, 2019
Collaborator
There was a problem hiding this comment.
I see we can not create tests but maybe it makes sense to add pending dump test to clearly show that we know about it?
Member
Author
|
It's part of the default cmdlets tests verifying it exists on Windows, but not Linux/macOS. Eventually, we want to investigate all pending tests and not have them pending. |
14 tasks
sdwheeler
added a commit
to sdwheeler/PowerShell
that referenced
this pull request
Oct 28, 2019
This is related to PowerShell#10909
sdwheeler
added a commit
to sdwheeler/PowerShell
that referenced
this pull request
Oct 28, 2019
This is related to PowerShell#10909
14 tasks
Member
|
I looked at emptying the macOS trash Some items the normal user doesn't have permissions to. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add back
Clear-RecycleBincmdlet for Windows for parity with Windows PowerShell. Addressed misuse of GetLastError() by removing error handling since the API returns error only if recycle bin is empty already which is not useful for this cmdlet.PR Context
FIx #6743
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.