10000 Add back `Out-Printer` command by SteveL-MSFT · Pull Request #10906 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add back Out-Printer command #10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 8 commits into from
Nov 1, 2019
Merged

Add back Out-Printer command #10906

adityapatwardhan merged 8 commits into from
Nov 1, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 26, 2019 •
edited
Loading

PR Summary

System System.Drawing is back, we can re-enable Out-Printer command. Manually validated using Out-Printer to pdf printer.

PR Context

Fix #10660

PR Checklist

@SteveL-MSFT SteveL-MSFT mentioned this pull request Oct 26, 2019
Closed
10 tasks
iSazonov
iSazonov reviewed Oct 28, 2019
View reviewed changes
@SteveL-MSFT SteveL-MSFT added Review - Committee The PR/Issue needs a review from the PowerShell Committee Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Oct 28, 2019
@sdwheeler
Copy link
Collaborator
sdwheeler commented Oct 28, 2019

@SteveL-MSFT The new FWLink for Out-Printer is https://go.microsoft.com/fwlink/?LinkID=2109553

@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 29, 2019

@PoshChan please retry static

@PoshChan
Copy link
Collaborator
PoshChan commented Oct 29, 2019

@SteveL-MSFT, successfully started retry of PowerShell-CI-static-analysis

iSazonov
iSazonov approved these changes Oct 29, 2019
View reviewed changes
Copy link
Collaborator
@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two minor comments.

adityapatwardhan
adityapatwardhan approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member
@adityapa 8000 twardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respond to comments from @iSazonov. Otherwise looks good.

SteveL-MSFT and others added 2 commits October 29, 2019 11:29
@adityapatwardhan
Copy link
Member
adityapatwardhan commented Oct 30, 2019

@SteveL-MSFT Please resolve merge conflicts

@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 31, 2019

I'll wait for GraphicalHost to be merged first as there will be another merge conflict
8000

@adityapatwardhan
Copy link
Member
adityapatwardhan commented Nov 1, 2019

@SteveL-MSFT Graphical host is merged. Please resolve merge conflict.

@adityapatwardhan
Copy link
Member
adityapatwardhan commented Nov 1, 2019

@PoshChan please remind me in 1 hour.

@PoshChan
Copy link
Collaborator
PoshChan commented Nov 1, 2019

@adityapatwardhan, this is the reminder you requested 1 hour. ago

@adityapatwardhan adityapatwardhan added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 1, 2019
@adityapatwardhan adityapatwardhan added this to the 7.0.0-preview.6 milestone Nov 1, 2019
@adityapatwardhan adityapatwardhan merged commit 6882ad5 into PowerShell:master Nov 1, 2019
@SteveL-MSFT SteveL-MSFT deleted the out-printer branch November 1, 2019 18:46
@KirkMunro KirkMunro mentioned this pull request Nov 2, 2019
Open
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

Bring back Out-Printer

5 participants

@SteveL-MSFT @sdwheeler @PoshChan @adityapatwardhan @iSazonov
0