8000 Update AppX Manifest and Packaging module to conform to MS Store requirements by SteveL-MSFT · Pull Request #10878 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Update AppX Manifest and Packaging module to conform to MS Store requirements #10878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 2 commits into from
Oct 24, 2019
Merged

Update AppX Manifest and Packaging module to conform to MS Store requirements #10878

TravisEz13 merged 2 commits into from
Oct 24, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 24, 2019 •
edited
Loading

PR Summary

Remove version from product name, it's just PowerShell or PowerShellPreview (dash is not acceptable). Display name is PowerShell or PowerShell Preview. The architecture is needed in the manifest so that we can bundle the x64, arm, and arm64 msix into a single msixbundle. Update msix function and yaml to pass runtime so that architecture is filled in correctly.

PR Checklist

@SteveL-MSFT
[package]
6fe18b1 
update manifest and packaging to conform to Store requirements
PoshChan
PoshChan reviewed Oct 24, 2019
View reviewed changes
@TravisEz13
Copy link
Member
TravisEz13 commented Oct 24, 2019

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator
PoshChan commented Oct 24, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 24, 2019
@TravisEz13 TravisEz13 added this to the 7.0.0-preview.6 milestone Oct 24, 2019
@TravisEz13 TravisEz13 merged commit 87bb1e6 into PowerShell:master Oct 24, 2019
@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@SteveL-MSFT SteveL-MSFT deleted the msix-pkg-arch branch June 6, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

3 participants

@SteveL-MSFT @TravisEz13 @PoshChan
0