Cleanup style in InitialSessionState.cs #10865
Conversation
There was a problem hiding this comment.
Some minor nits and suggestions. Otherwise looks good!
Thanks for taking the time to sort this out! 😊
There was a problem hiding this comment.
Why the change of exception type? 🙂
There was a problem hiding this comment.
These look fairly long... we might be better off putting every parameter on its own line. 🤔
There was a problem hiding this comment.
This one seems to be just long enough to be on one line, but ok with either.
There was a problem hiding this comment.
The line break before = doesn't seem necessary. The rest is good though! 👍
There was a problem hiding this comment.
I will fix in last commit or in follow PR - the file contains still many style issues.
There was a problem hiding this comment.
Appreciate you taking the time to clean up old code in such an organised manner! 💖 😊
There was a problem hiding this comment.
We have already seen that it significantly reduces the time for PR passing through code review.
7ee5b2b to
21e8aa5
Compare
There was a problem hiding this comment.
This one seems to be just long enough to be on one line, but ok with either.
Co-Authored-By: Steve Lee <slee@microsoft.com>
Co-Authored-By: Steve Lee <slee@microsoft.com>
|
🎉 Handy links: |
PR Summary
Follow #10368
Fix style issues in InitialSessionState.cs file.
Please review commit by commit. There is a lot of commits but everyone is small and simple.
PR Context
CodeFactor has two nice metrics:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.