8000 Take ComputerName via Pipeline in Get-HotFix by kvprasoon · Pull Request #10852 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Take ComputerName via Pipeline in Get-HotFix #10852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 9 commits into from
Nov 1, 2019
Merged

Take ComputerName via Pipeline in Get-HotFix #10852

iSazonov merged 9 commits into from
Nov 1, 2019

Conversation

@kvprasoon
Copy link
Contributor
@kvprasoon kvprasoon commented Oct 20, 2019 •
edited
Loading

Get-HotFix support accepting -ComputerName via pipeline but when used it doesn't consider computers other than localhost.

PR Context

PR Checklist

@kvprasoon
Copy link
Contributor Author
kvprasoon commented Oct 20, 2019

Pester tests has to be added, but would like to get comments on the code changes before that.

iSazonov
iSazonov reviewed Oct 20, 2019
View reviewed changes
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 20, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Oct 20, 2019
@iSazonov
Copy link
Collaborator
iSazonov commented Oct 22, 2019

Please look CodeFactor issues and add tests.

@kvprasoon
Copy link
Contributor Author
kvprasoon commented Oct 22, 2019

@iSazonov sure, but I don't know hot fix the 3rd finding in code factor (Complex Method)

@iSazonov
Copy link
Collaborator
iSazonov commented Oct 22, 2019

@kvprasoon Please ignore Complex Method.

@kvprasoon kvprasoon changed the title WIP: Get-HotFix to take ComputerName via Pipeline Get-HotFix to take ComputerName via Pipeline Oct 22, 2019
@iSazonov iSazonov requested a review from SteveL-MSFT October 23, 2019 17:04
@iSazonov
Copy link
Collaborator
iSazonov commented Oct 30, 2019

@SteveL-MSFT Could you please review?

Also we need new Help FWLink for the cmdlet /cc @sdwheeler

@iSazonov iSazonov self-assigned this Oct 30, 2019
@sdwheeler
Copy link
Collaborator
sdwheeler commented Oct 30, 2019 •
edited by unfurl-links bot
Loading

@SteveL-MSFT New FWLink for Get-Hotfix https://go.microsoft.com/fwlink/?linkid=2109716

The Get-Hotfix cmdlet gets hotfixes, or updates, that are installed on the local computer or specified remote computers. The updates can be installed by Windows Update, Microsoft Update, Windows Server Update Services, or manually installed.

SteveL-MSFT
SteveL-MSFT requested changes Oct 30, 2019
View reviewed changes
Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kvprasoon can you update the fwlink? You'll also need to update a test csv file

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 30, 2019
@iSazonov
Copy link
Collaborator
iSazonov commented Oct 31, 2019

It is V2Cmdlets.csv file.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 31, 2019
@kvprasoon
Copy link
Contributor Author
kvprasoon commented Oct 31, 2019

@SteveL-MSFT I've updated the FWLink.

@iSazonov Thanks for letting me know the filename.

@iSazonov iSazonov merged commit 5a76137 into PowerShell:master Nov 1, 2019
@iSazonov iSazonov changed the title Get-HotFix to take ComputerName via Pipeline Take ComputerName via Pipeline in Get-HotFix Nov 1, 2019
@iSazonov
Copy link
Collaborator
iSazonov commented Nov 1, 2019

@kvprasoon Thanks for your contribution!

@ghost
Copy link
ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@Maamue Maamue mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

4 participants

@kvprasoon @iSazonov @sdwheeler @SteveL-MSFT
0