8000 Cleanups in command discovery by iSazonov · Pull Request #10815 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Cleanups in command discovery #10815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 6 commits into from
Dec 3, 2019
Merged

Cleanups in command discovery #10815

iSazonov merged 6 commits into from
Dec 3, 2019

Conversation

@iSazonov
Copy link
Collaborator
@iSazonov iSazonov commented Oct 17, 2019 •
edited
Loading

PR Summary

Some cleanups in the command discovery code after investigating a performance:

  • Remove unused code.
  • Enable nullable reference types in CommandPathSearch.cs.
  • Add tests for discovery native commands.
  • Reduce allocations in GetAliasTable().
  • Remove searching by extensions (ignore PATHEXT environment variable) on Unix

PR Context

Related to #6577.

PR Checklist

PoshChan
PoshChan reviewed Oct 17, 2019
View reviewed changes
PoshChan
PoshChan reviewed Oct 17, 2019
View reviewed changes
PoshChan
PoshChan reviewed Oct 17, 2019
View reviewed changes
@iSazonov iSazonov force-pushed the perf-command-discovery-1 branch from 68d64dd to 581670f Compare October 17, 2019 10:08
PoshChan
PoshChan reviewed Oct 17, 2019
View reviewed changes
PoshChan
PoshChan reviewed Oct 17, 2019
View reviewed changes
PoshChan
PoshChan reviewed Oct 17, 2019
View reviewed changes
PoshChan
PoshChan reviewed Oct 17, 2019
View reviewed changes
@iSazonov iSazonov mentioned this pull request Oct 18, 2019
Closed
@iSazonov iSazonov force-pushed the perf-command-discovery-1 branch from fe736e5 to c4554bc Compare October 21, 2019 12:08
@iSazonov iSazonov force-pushed the perf-command-discovery-1 branch from c4554bc to 1cb0ea6 Compare November 19, 2019 09:30
@iSazonov iSazonov changed the title WIP: Performance improvements in command discovery Performance improvements in command discovery Nov 19, 2019
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 19, 2019
@iSazonov iSazonov changed the title Performance improvements in command discovery Cleanups in command discovery Nov 19, 2019
@iSazonov iSazonov self-assigned this Nov 19, 2019
PoshChan
PoshChan reviewed Nov 19, 2019
View reviewed changes
SteveL-MSFT
SteveL-MSFT approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One NIT for consistency

@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Dec 3, 2019
@iSazonov iSazonov force-pushed the perf-command-discovery-1 branch from 14f7a30 to 31ef215 Compare December 3, 2019 05:03
@iSazonov iSazonov requested a review from daxian-dbw as a code owner December 3, 2019 05:29
@iSazonov iSazonov force-pushed the perf-command-discovery-1 branch from a070d2c to be15c40 Compare December 3, 2019 05:51
@iSazonov iSazonov force-pushed the perf-command-discovery-1 branch from be15c40 to 0e95719 Compare December 3, 2019 05:59
@iSazonov
Copy link
Collaborator Author
iSazonov commented Dec 3, 2019

Fix HelpUri for Stop-Computer to pass CIs on Unix.

@iSazonov iSazonov merged commit 42f21ae into PowerShell:master Dec 3, 2019
@iSazonov iSazonov deleted the perf-command-discovery-1 branch December 3, 2019 06:23
@ghost
Copy link
ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Re 685C viewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@rjmholt rjmholt Awaiting requested review from rjmholt

@anmenaga anmenaga Awaiting requested review from anmenaga

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@iSazonov @SteveL-MSFT @PoshChan
0