Fix stringdata test to correctly validate keys of hashtables #10810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoshChan
reviewed
Oct 16, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Oct 17, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Oct 18, 2019
Collaborator
|
@SteveL-MSFT Please rebase to pass CI-Windows. |
6bffbef to
a78a73d
Compare
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Nov 9, 2019
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The previous test wasn't correctly validating the keys in the hashtable match expected and actual. Fix is to update the test cases so the expected hashtable has the right key names and remove the unnecessary
foreachloop (since we know the hashtable only has one entry) and verify the key and the value.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.