8000 Disable strict mode in `Get-Error` formatting script by SteveL-MSFT · Pull Request #10800 · PowerShell/PowerShell · GitHub 10BC0
[go: up one dir, main page]
Skip to content

Disable strict mode in Get-Error formatting script #10800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 2 commits into from
Oct 18, 2019
Merged

Disable strict mode in Get-Error formatting script #10800

adityapatwardhan merged 2 commits into from
Oct 18, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 16, 2019 •
edited
Loading

PR Summary

Need to disable strict mode as the formatting script is dealing with lots of different types of objects dynamically. If user uses Set-StrictMode then this formatting fails to render anything. Fix is to disable strict mode within the scope of this script. Also rename the label of ErrorIdentifier to ErrorIndex.

PR Checklist

@SteveL-MSFT SteveL-MSFT added this to the 7.0.0-preview.5 milestone Oct 16, 2019
@adityapatwardhan adityapatwardhan added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 18, 2019
@adityapatwardhan adityapatwardhan merged commit 3806c39 into PowerShell:master Oct 18, 2019
kilasuit pushed a commit to kilasuit/PowerShell that referenced this pull request Nov 9, 2019
@SteveL-MSFT @kilasuit
Disable strict mode in Get-Error formatting script (PowerShell#10800)
22f3d0a
@SteveL-MSFT SteveL-MSFT deleted the geterror-strictmode branch June 6, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.6

Development

Successfully merging this pull request may close these issues.

3 participants

@SteveL-MSFT @adityapatwardhan @iSazonov
0