Remove unused SourceLength remoting property causing formatting issues
#10765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHigin
approved these changes
Oct 10, 2019
SourceLength remoting property causing formatting issuesSourceLength remoting property causing formatting issues
iSazonov
approved these changes
Oct 11, 2019
Collaborator
|
No problems with Windows PowerShell remoting compatibility? |
Member
Author
|
@iSazonov looked in the Windows PowerShell code base and this property isn't used either |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
#8785 exposed an issue where part of that optimization is seeing if the object has special remoting note properties. One of them was simply called
Lengthand if so then formatting simply usedToString()which is undesired in this case. This is a very specific case where it is an object that contains only a member calledLength. Searching the codebase, it appearsSourceLengthisn't actually used, so the fix is to remove this property and the check for it.PR Context
Fix #10762
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.