8000 Check `pwsh.exe` and `pwsh` in daily version on Windows by centreboard · Pull Request #10738 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Check pwsh.exe and pwsh in daily version on Windows #10738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Oct 10, 2019
Merged

Check pwsh.exe and pwsh in daily version on Windows #10738

TravisEz13 merged 1 commit into from
Oct 10, 2019

Conversation

@centreboard
Copy link
Contributor
@centreboard centreboard commented Oct 8, 2019

PR Summary

Check for pwsh.exe on Windows to get the daily version currently installed

PR Context

Improves on #10489
On Windows pwsh doesn't exist so the same daily version was reinstalled when calling
iex "& {$(irm aka.ms/install-powershell.ps1)} -Daily"

PR Checklist

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 8, 2019

There is a failure unrelated to your change, which is blocking this PR.
https://powershell.visualstudio.com/PowerShell/_build/results?buildId=34391&view=logs&jobId=68b94060-b87a-5de8-40f0-78718e402518&taskId=50e847f0-73a2-533f-c084-25a3970df96e&lineStart=36&lineEnd=37&colStart=1&colEnd=1
Do you want to fix or do you want me to?

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Oct 9, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Oct 9, 2019
@centreboard
Copy link
Contributor Author
centreboard commented Oct 9, 2019

@TravisEz13 Could you please look at it? I don't have a mac and naively replacing caskroom/cask with homebrew/cask-cask didn't work for me in Azure Pipelines.

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 9, 2019

I've opened #10752 to fix the issue. I'll help update this PR once we have fixed that issue.

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 9, 2019

The other PR was merged. I retried your test.

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 9, 2019

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator
PoshChan commented Oct 9, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13 TravisEz13 changed the title Check pwsh.exe daily version on Windows Check pwsh.exe and pwsh in daily version on Windows Oct 10, 2019
@TravisEz13 TravisEz13 merged commit 54fd7d8 into PowerShell:master Oct 10, 2019
@TravisEz13
Copy link
Member
TravisEz13 commented Oct 10, 2019

Thanks for your contribution

@bergmeister
Copy link
Contributor
bergmeister commented Oct 11, 2019

Awesome, thanks :-)

@ghost
Copy link
ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.5

Development

Successfully merging this pull request may close these issues.

5 participants

@centreboard @TravisEz13 @PoshChan @bergmeister @iSazonov
0