Adding positional parameter for ScriptBlock when using Invoke-Command with SSH #10721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
I've added two simple tests which are checking for a System.ArguemenException when calling Invoke-Method with the positional parameter for ScriptBlock. Please let me know if this is enough or if we should verify with a real SSH-connection (if that's possible in during the CI-test). |
iSazonov
approved these changes
Oct 8, 2019
adityapatwardhan
requested changes
Oct 8, 2019
| Should -Not -Throw -ErrorId "System.ArgumentException,Microsoft.PowerShell.Commands.InvokeCommandCommand" | ||
| } | ||
|
|
||
| It "Invoke-Command should support poisitonal parameter ScriptBlock when using SSHConnection" { |
Member
There was a problem hiding this comment.
typo in poisitonal -> positional
| } | ||
|
|
||
| It "Invoke-Command should support positional parameter ScriptBlock when using HostName" { 8000 | ||
| { Invoke-Command -HostName localhost { "test" } } | |
Member
There was a problem hiding this comment.
Instead of checking it in this way, i would prefer checking it using command metadata. I have a sample here:
Describe "sdfsf" {
It "Invoke-Command should support positional parameter ScriptBlock when using parameter set '<ParameterSetName>'" -TestCases @{ParameterSetName = 'SSHHost'}, @{ParameterSetName = 'SSHHostHashParam'} {
param ($ParameterSetName)
$commandInfo = Get-Command -Name Invoke-Command
$sshHostParameters = $commandInfo.ParameterSets | Where-Object { $_.Name -eq $ParameterSetName }
$sshHostSBPostion = $sshHostParameters.Parameters | Where-Object { $_.name -eq 'ScriptBlock' } | Select-Object -ExpandProperty position
$sshHostSBPostion | Should -Be 1
}
}| } | ||
|
|
||
| It "Invoke-Command should support poisitonal parameter ScriptBlock when using SSHConnection" { | ||
| { Invoke-Command -SSHConnection @{ HostName = "localhost" } { "test" } } | |
iSazonov
approved these changes
Oct 10, 2019
adityapatwardhan
approved these changes
Oct 10, 2019
Member
|
@machgo Thank you for your contribution |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds the PositionalParameter Scriptblock when using Invoke-Command with the new -Hostname or -SSHConnection parameters.
This allows to use the same usage as when using WinRM with -Computername
examples:
{ Invoke-Command -HostName localhost { 'test' } }{ Invoke-Command -SSHConnection @{ HostName = 'localhost' } { 'test' } }PR Context
fixes #10708
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.