Set current working directory of each ForEach-Object -Parallel running script to the same location as the calling script. #10672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the same location as the calling script.
iSazonov
approved these changes
Oct 2, 2019
Collaborator
There was a problem hiding this comment.
LGTM with one minor comment.
rjmholt
reviewed
Oct 3, 2019
iSazonov
reviewed
Oct 3, 2019
iSazonov
reviewed
Oct 3, 2019
rjmholt
approved these changes
Oct 3, 2019
|
🎉 Handy links: |
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Nov 9, 2019
…ing script to the same location as the calling script. (PowerShell#10672)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This changes fixes issue, #10537. It sets each parallel running script block context to have the same working directory location as the calling script.
PR Context
Previously, parallel running script blocks would use the default PowerShell working directory, similar to remoting and job execution. But ForEach-Object -Parallel should run all script in the same working directory as the calling script, to make it consistent with ForEach-Object while running in normal (non-parallel) mode.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.