8000 Add -Delimiter to ConvertFrom-StringData by steviecoaster · Pull Request #10665 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add -Delimiter to ConvertFrom-StringData #10665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmenaga merged 10 commits into from
Oct 11, 2019
Merged

Add -Delimiter to ConvertFrom-StringData #10665

anmenaga merged 10 commits into from
Oct 11, 2019

Conversation

@steviecoaster
Copy link
Contributor
@steviecoaster steviecoaster commented Oct 1, 2019 •
edited
Loading

PR Summary

This PR adds the ability to specify a delimiter to the ConvertFrom-StringData cmdlet

PR Context

ConvertFrom-StringData is powerful, but not very discoverable. This addition eases usability of the cmdlet to work with many string formats easily.

PR Checklist

iSazonov
iSazonov reviewed Oct 1, 2019
View reviewed changes
Copy link
Collaborator
@iSazonov iSazonov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new tests and update existing tests.

You should sigh CLA before we can merge the PR.

iSazonov
iSazonov reviewed Oct 2, 2019
View reviewed changes
@steviecoaster steviecoaster mentioned this pull request Oct 2, 2019
Closed
8 tasks
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 9, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Oct 9, 2019
iSazonov
iSazonov approved these changes Oct 9, 2019
View reviewed changes
Copy link
Collaborator
@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two style comments.

@anmenaga
Copy link
anmenaga commented Oct 11, 2019

CI passed on rebuild.

@anmenaga anmenaga merged commit 6a807a2 into PowerShell:master Oct 11, 2019
@vexx32
Copy link
Collaborator
vexx32 commented Oct 12, 2019

Nice work @steviecoaster! 💖

@iSazonov
Copy link
Collaborator
iSazonov commented Oct 12, 2019

@steviecoaster Thanks for your contribution!

@ghost
Copy link
ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@iSazonov
Copy link
Collaborator
iSazonov commented Oct 24, 2019

@chuanjiao10 Please open new issue with your feedback.

kilasuit pushed a commit to kilasuit/PowerShell that referenced this pull request Nov 9, 2019
@steviecoaster @kilasuit
Add -Delimiter to ConvertFrom-StringData (PowerShell#10665)
73d95b9 
@steviecoaster Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

+2 more reviewers

@vexx32 vexx32 vexx32 left review comments

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.5

Development

Successfully merging this pull request may close these issues.

4 participants

@steviecoaster @anmenaga @vexx32 @iSazonov
0