Add back newline for grouping with Format-Table and -Property
#10653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
approved these changes
Oct 1, 2019
anmenaga
reviewed
Oct 1, 2019
There was a problem hiding this comment.
Can you please add 'before change' and 'after change' screenshots to PR description?
When I'm trying this on 7.0.0-preview.3 I see missing newlines only when -Property is specified (in addition to -GroupBy), while PR reads like this should happen always when -GroupBy is used.
Format-TableFormat-Table and -Property
Member
Author
|
@anmenaga updated title, description, and added screenshots. It only affects |
anmenaga
approved these changes
Oct 2, 2019
|
🎉 Handy links: |
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When using
Format-Tableexplicitly with-Propertyand-Grouping, it was missing a newline between the group and the content. Fix is to add back a newline after writing the grouping information. Also changed the default formatting of cert, registry, and files so that when there is grouping, it doesn't insert an extra newline (resulting in two). Because of the way formatting works, needed to remove use of the indent param and simply insert the indention into the resx string.Before this change:
After this change:
dirwith default table formatting is the same, but the changes were needed to keep them the same.PR Context
Fix #9299
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.