8000 Add env var to differentiate client/server telemetry in MSI by SteveL-MSFT · Pull Request #10612 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add env var to differentiate client/server telemetry in MSI #10612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 2 commits into from
Sep 24, 2019
Merged

Add env var to differentiate client/server telemetry in MSI #10612

TravisEz13 merged 2 commits into from
Sep 24, 2019

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Sep 24, 2019 •
edited
Loading

PR Summary

When installed via MSI, create POWERSHELL_DISTRIBUTION_CHANNEL env var that will be picked up by telemetry to report if the Windows system is client or server by using: msi:<ProductName> where is retrieved from the registry under HKLM:\Software\Microsoft\Windows NT\CurrentVersion\ProductName.

Also fixed some formatting of the xml where it was one column over too much.

PR Context

Currently, we have no way to differentiating client and server skus from our Windows telemetry.

PR Checklist

@SteveL-MSFT
[package]
cb4c3d4 
add env var to differentiate client/server in telemetry when installed via MSI
TravisEz13
TravisEz13 reviewed Sep 24, 2019
View reviewed changes
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 24, 2019
@TravisEz13 TravisEz13 added this to the 7.0.0-preview.5 milestone Sep 24, 2019
@SteveL-MSFT SteveL-MSFT changed the title Add env var to differentiate client/server in telemetry when installed via MSI WIP:Add env var to differentiate client/server in telemetry when installed via MSI Sep 24, 2019
@SteveL-MSFT SteveL-MSFT changed the title WIP:Add env var to differentiate client/server in telemetry when installed via MSI Add env var to differentiate client/server in telemetry when installed via MSI Sep 24, 2019
@SteveL-MSFT
[package]
8358ea8 
Change id to use PascalCasing to be consistent
@TravisEz13 TravisEz13 changed the title Add env var to differentiate client/server in telemetry when installed via MSI Add env var to differentiate client/server telemetry in MSI Sep 24, 2019
@TravisEz13 TravisEz13 merged commit 146f11b into PowerShell:master Sep 24, 2019
@ghost
Copy link
ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@SteveL-MSFT SteveL-MSFT deleted the msi-telemetry branch June 6, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.5

Development

Successfully merging this pull request may close these issues.

2 participants

@SteveL-MSFT @TravisEz13
0