8000 Make `Add-Type` usable in application that hosts PowerShell by daxian-dbw · Pull Request #10587 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Make Add-Type usable in application that hosts PowerShell #10587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 6 commits into from
Sep 25, 2019
Merged

Make Add-Type usable in application that hosts PowerShell #10587

adityapatwardhan merged 6 commits into from
Sep 25, 2019

Conversation

@daxian-dbw
Copy link
Member
@daxian-dbw daxian-dbw commented Sep 20, 2019 •
edited
Loading

PR Summary

Fix #9587

  • Make the NuGet package Microsoft.PowerShell.SDK ship the ref folder, which will be copied to the right place for dotnet build and dotnet publish.
  • Make change in Add-Type to look for the ref folder at the folder where EntryAssembly is located. In case of pwsh, it's the folder that contains pwsh.dll.
  • Add a hosting test to make sure Add-Type works for an application that hosts powershell.

PR Context

PR Checklist

@daxian-dbw daxian-dbw removed the request for review from JamesWTruher September 20, 2019 23:06
iSazonov
iSazonov reviewed Sep 21, 2019
View reviewed changes
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 21, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Sep 21, 2019
@daxian-dbw
Copy link
Member Author
daxian-dbw commented Sep 23, 2019

/cc @TylerLeonhardt

TylerLeonhardt
TylerLeonhardt approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member
@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a small change for big impact 😊 LGTM

PaulHigin
PaulHigin approved these changes Sep 24, 2019
View reviewed changes
@adityapatwardhan adityapatwardhan merged commit 7451792 into PowerShell:master Sep 25, 2019
@daxian-dbw daxian-dbw deleted the addtype branch September 25, 2019 23:26
@ghost
Copy link
ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 23, 2019
Closed
@iSazonov iSazonov mentioned this pull request Oct 24, 2019
Closed
8 tasks
@iSazonov iSazonov mentioned this pull request Nov 21, 2019
Closed
@iSazonov iSazonov mentioned this pull request Dec 11, 2019
Closed
@Francisco-Gamino Francisco-Gamino mentioned this pull request Jan 7, 2020
Closed
@ghost
Copy link
ghost commented Jan 27, 2020

🎉v6.2.4 has been released which incorporates this pull request.:tada:

Handy links:

@TylerLeonhardt
Copy link
Member
TylerLeonhardt commented Jan 27, 2020

@Francisco-Gamino fyi

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Feb 25, 2020
@daxian-dbw @adityapatwardhan
Make Add-Type usable in application that hosts PowerShell (PowerShe…
8000
82fc0f7 
…ll#10587)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+3 more reviewers

@PoshChan PoshChan PoshChan left review comments

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

6.2.4

Development

Successfully merging this pull request may close these issues.

'Add-Type' doesn't work in applications that host powershell

7 participants

@daxian-dbw @TylerLeonhardt @adityapatwardhan @PaulHigin @iSazonov @PoshChan @TravisEz13
0