10000 Replace 'api-ms-win-core-job-12-1-0.dll' with 'Kernell32.dll' by iSazonov · Pull Request #10417 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Replace 'api-ms-win-core-job-12-1-0.dll' with 'Kernell32.dll' #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 2 commits into from
Sep 3, 2019
Merged

Replace 'api-ms-win-core-job-12-1-0.dll' with 'Kernell32.dll' #10417

adityapatwardhan merged 2 commits into from
Sep 3, 2019

Conversation

@iSazonov
Copy link
Collaborator
@iSazonov iSazonov commented Aug 22, 2019 •
edited
Loading

PR Summary

Fix #6561

PR Context

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 22, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.4 milestone Aug 22, 2019
@adityapatwardhan
Copy link
Member
adityapatwardhan commented Aug 26, 2019

@iSazonov The same DLL is used by AssignProcessToJobObjectDllName and QueryInformationJobObjectDllName. Do these also not work on Win7?

If we are replacing them with kernel32.dll, have you verified the change on win7throughwin10`?

If replacing with kernel32.dll works, should we be removing the definitions from PInvokeDllNames.cs.

@iSazonov
Copy link
Collaborator Author
iSazonov commented Aug 27, 2019

@adityapatwardhan I removed all links to api-ms-win-core-job-l2-1-0.dll and now it works for me on Windows 7.

should we be removing the definitions from PInvokeDllNames.cs

There is already some unused consts, the list is large and numerated, also we could want to use ApiSets again after Windows 7 EOL. I think we need to keep the consts.

@daxian-dbw
Copy link
Member
daxian-dbw commented Aug 29, 2019

Do we know if things are still working properly on NanoServer and Windows IoT after changing to kernal32.dll?

@iSazonov
< 8000 /svg> Copy link
Collaborator Author
iSazonov commented Aug 30, 2019 •
edited by unfurl-links bot
Loading

I can not test on Nano and IoT.
I saw that .Net Core team replaced ApiSets with direct dll names because of many such problems with ApiSets.
See:
dotnet/corefx@75e45da
More: https://github.com/dotnet/corefx/search?q=ApiSets&type=Commits

Also I found https://www.geoffchappell.com/studies/windows/win32/apisetschema/history/sets61.htm where we can see that there is sometimes automapping (for Windows 7).

@adityapatwardhan
Copy link
Member
adityapatwardhan commented Sep 3, 2019

I have verified that the change works on NanoServer 1903 image.

@adityapatwardhan adityapatwardhan merged commit bbd54c3 into PowerShell:master Sep 3, 2019
@iSazonov iSazonov deleted the fix-unable-load-dll-api-ms-win-core branch September 4, 2019 03:12
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Sep 14, 2019
@iSazonov @TravisEz13
Replace api-ms-win-core-job-12-1-0.dll with Kernell32.dll (PowerS…
5e23208 
…hell#10417)
@ghost
Copy link
ghost commented Sep 19, 2019

🎉v7.0.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Sep 19, 2019
Closed
@ForNeVeR
Copy link
Contributor
ForNeVeR commented Sep 21, 2019

Hey, shouldn't we remove the corresponding constants from the PinvokeDllNames class since they are unused now?

@iSazonov
Copy link
Collaborator Author
iSazonov commented Sep 21, 2019

@ForNeVeR We did not remove the constants because we will revert the change after Windows 7 EOL.

@ForNeVeR
Copy link
Contributor
ForNeVeR commented Sep 21, 2019

Okay, thanks.

This was referenced Sep 29, 2019
Closed
Merged
@adityapatwardhan adityapatwardhan removed this from the 6.2.4-approved milestone Jan 18, 2020
@adityapatwardhan adityapatwardhan added this to the 6.2.4 milestone Jan 18, 2020
@ghost
Copy link
ghost commented Jan 27, 2020

🎉v6.2.4 has been released which incorporates this pull request.:tada:

Handy links:

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Feb 25, 2020
@iSazonov @adityapatwardhan
Replace api-ms-win-core-job-12-1-0.dll with Kernell32.dll (PowerS…
3b83ab2 
…hell#10417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

6.2.4

Development

Successfully merging this pull request may close these issues.

Start-Process: Unable to load DLL 'api-ms-win-core-job-12-1-0.dll'

5 participants

@iSazonov @adityapatwardhan @daxian-dbw @ForNeVeR @TravisEz13
0