8000 Remove WorkflowJobSourceAdapter reference by KirkMunro · Pull Request #10326 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Remove WorkflowJobSourceAdapter reference #10326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Sep 17, 2019
Merged

Remove WorkflowJobSourceAdapter reference #10326

iSazonov merged 1 commit into from
Sep 17, 2019

Conversation

@KirkMunro
Copy link
Contributor
@KirkMunro KirkMunro commented Aug 8, 2019

PR Summary

This PR removes a reference to WorkflowJobSourceAdapter that is no longer used, as part of the workflow cleanup.

PR Context

See issue #9570.

PR Checklist

@KirkMunro KirkMunro requested a review from PaulHigin as a code owner August 8, 2019 20:02
@KirkMunro KirkMunro mentioned this pull request Aug 8, 2019
Closed
15 tasks
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Aug 8, 2019
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 9, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.3 milestone Aug 9, 2019
@iSazonov iSazonov requested a review from SteveL-MSFT August 9, 2019 11:31
@iSazonov iSazonov self-assigned this Aug 9, 2019
@iSazonov
Copy link
Collaborator
iSazonov commented Aug 20, 2019

@PaulHigin Please update your code review.

@KirkMunro
Copy link
Contributor Author
KirkMunro commented Sep 4, 2019

@SteveL-MSFT This PR is waiting for your review. All it does is remove an if clause related to workflow, replacing the entire if/else statement with the body of the else clause. No other code has changed, should be quick and easy.

@iSazonov
Copy link
Collaborator
iSazonov commented Sep 16, 2019

@SteveL-MSFT Have you any thoughts about the PR?

@iSazonov iSazonov merged commit ee8e4e0 into PowerShell:master Sep 17, 2019
@KirkMunro KirkMunro deleted the deprecate-workflow-job-source-adapter branch September 17, 2019 12:38
@ghost
Copy link
ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

+2 more reviewers

@PoshChan PoshChan PoshChan left review comments

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.5

Development

Successfully merging this pull request may close these issues.

6 participants

@KirkMunro @iSazonov @SteveL-MSFT @PaulHigin @PoshChan @TravisEz13
0