8000 $PSCulture follows CurrentThread.CurrentCulture by iSazonov · Pull Request #10138 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

$PSCulture follows CurrentThread.CurrentCulture #10138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 3 commits into from
Oct 7, 2019
Merged

$PSCulture follows CurrentThread.CurrentCulture #10138

iSazonov merged 3 commits into from
Oct 7, 2019

Conversation

@iSazonov
Copy link
Collaborator
@iSazonov iSazonov commented Jul 12, 2019 •
edited
Loading

PR Summary

Now $PSCulture gets the value from CurrentThread.CurrentCulture

Close #3831

PowerShell Committee approved the change in #3831

PR Context

PR Checklist

@iSazonov iSazonov added Committee-Reviewed PS-Committee has reviewed this and made a decision CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log labels Jul 12, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.2 milestone Jul 12, 2019
@iSazonov iSazonov self-assigned this Jul 12, 2019
PoshChan
PoshChan reviewed Jul 12, 2019
View reviewed changes
PoshChan
PoshChan reviewed Jul 12, 2019
View reviewed changes
PoshChan
PoshChan reviewed Jul 12, 2019
View reviewed changes
@iSazonov
Copy link
Collaborator Author
iSazonov commented Jul 12, 2019

@PoshChan Please restart Macos

@iSazonov
8000 Copy link
Collaborator Author
iSazonov commented Jul 12, 2019

@PoshChan Please retry Macos

@PoshChan
Copy link
Collaborator
PoshChan commented Jul 12, 2019

@iSazonov, successfully started retry of PowerShell-CI-macOS

@PowerShell PowerShell deleted a comment from PoshChan Jul 12, 2019
@iSazonov iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Jul 12, 2019
TravisEz13
TravisEz13 reviewed Jul 12, 2019
View reviewed changes
@iSazonov iSazonov mentioned this pull request Jul 29, 2019
Closed
8 tasks
@iSazonov iSazonov removed the Documentation Needed in this repo Documentation is needed in this repo label Jul 29, 2019
@iSazonov
Copy link
Collaborator Author
iSazonov commented Aug 20, 2019

@SteveL-MSFT @TravisEz13 Since the PR was approved by PowerShell Committee please review the code.

@iSazonov iSazonov force-pushed the psculture-from-thread branch from 597ba0e to da528d0 Compare August 30, 2019 07:36
@iSazonov
Copy link
Collaborator Author
iSazonov commented Aug 30, 2019

Rebased to get latest updates.

@TravisEz13 TravisEz13 removed this from the 7.0.0-preview.4 milestone Sep 12, 2019
@TravisEz13 TravisEz13 added this to the 7.0.0-preview.5 milestone Sep 12, 2019
@iSazonov
Copy link
Collaborator Author
iSazonov commented Sep 17, 2019

@SteveL-MSFT @TravisEz13 Could you please continue the review?

@iSazonov
Copy link
Collaborator Author
iSazonov commented Sep 20, 2019

@SteveL-MSFT Have you any concerns about the PR?

@iSazonov
Copy link
Collaborator Author
iSazonov commented Oct 2, 2019

@SteveL-MSFT Friendly ping.

@iSazonov iSazonov merged commit 6a36bb4 into PowerShell:master Oct 7, 2019
@iSazonov iSazonov deleted the psculture-from-thread branch October 7, 2019 09:17
@ghost
Copy link
ghost commented Oct 23, 2019
8000

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

7.0.0-preview.5

Development

Successfully merging this pull request may close these issues.

Get-Culture and $PSCulture do not (consistently) reflect in-session changes to another culture

3 participants

@iSazonov @PoshChan @TravisEz13
0